More patching
My patch for
ticket 18314 from last week was committed. It's not exactly surprising but I find it quite exciting to have made a successful contribution. In light of this I decided to make a much bigger contribution this week. Since there was still plenty to do on ticket 18314, I decided to do more. I went through the entire 7402 line wp-admin.dev.css file, fixed formatting errors/inconsistencies, and combined duplicate rules wherever possible. The resulting diff file is now in trac waiting for someone to come along and review/commit it.
css observations
There was one point where I combined some duplicate rules involving css 3 transitions and I had to test out the code to make sure I understood transitions correctly and wasn't going to mess something up. In the process I discovered that css transitions are really cool.
I also noticed some clear evidence of the file having been written by many different people. There would be stretches where the style was really clear and polished and the stretches where people had put too many carriage returns or omitted carriage returns that for consistency were necessary. These sorts of things are of course irrelevant to the end user, who gets a minified version anyway but nice for developers.
It felt a bit daunting at times making judgement calls on things but I suppose this is just what has to be done in open source.
emacs
I did all of this in emacs because I was on a remote server and wanted to gain familiarity with it. I learned a fair bit of emacs but I'm still having trouble installing language modes.
